Discussion:
Propose to MDB_PICKUP for mdb_dpi_open()
Леонид Юрьев
2015-04-30 15:38:04 UTC
Permalink
Hi, Howard.

I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe

At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.

Leonid.
Howard Chu
2015-04-30 16:16:24 UTC
Permalink
Content preview: Леонид Юрьев wrote: > Hi, Howard. > > I would like
to introduce the MDB_PICKUP flag for mdb_dpi_open(). > Please see > https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
Post by Леонид Юрьев
Post by Леонид Юрьев
At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN. [...]
Content analysis details: (-4.2 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium
trust
[69.43.206.106 listed in list.dnswl.org]
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
Cc: openldap-***@openldap.org
X-BeenThere: openldap-***@openldap.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OpenLDAP development discussion list <openldap-devel.openldap.org>
List-Unsubscribe: <http://www.openldap.org/lists/mm/options/openldap-devel>,
<mailto:openldap-devel-***@openldap.org?subject=unsubscribe>
List-Archive: <http://www.openldap.org/lists/openldap-devel/>
List-Post: <mailto:openldap-***@openldap.org>
List-Help: <mailto:openldap-devel-***@openldap.org?subject=help>
List-Subscribe: <http://www.openldap.org/lists/mm/listinfo/openldap-devel>,
<mailto:openldap-devel-***@openldap.org?subject=subscribe>
Errors-To: openldap-devel-***@openldap.org
Sender: "openldap-devel" <openldap-devel-***@openldap.org>
X-Spam-Score: -4.2 (----)
X-Spam-Report: Spam detection software, running on the system "gauss.openldap.net", has
identified this incoming email as possible spam. The original message
has been attached to this so you can view it (if it isn't spam) or label
similar future email. If you have any questions, see
the administrator of that system for details.

Content preview: Леонид Юрьев wrote: > Hi, Howard. > > I would like
to introduce the MDB_PICKUP flag for mdb_dpi_open(). > Please see > https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
Post by Леонид Юрьев
Post by Леонид Юрьев
At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN. [...]
Content analysis details: (-4.2 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium
trust
[69.43.206.106 listed in list.dnswl.org]
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
Post by Леонид Юрьев
Hi, Howard.
I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.
This flag is completely unnecessary. Opening an existing DBI with
flags=0 accomplishes that task already.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Howard Chu
2015-04-30 16:46:35 UTC
Permalink
Content preview: Леонид Юрьев wrote: > Hm, but how open dbi which
some flags, ensure that are present? > > Same for main-dbi without change
stored flags? If you want to verify which flags are present, use mdb_dbi_flags()
to retrieve them after opening. [...]

Content analysis details: (-4.2 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium
trust
[69.43.206.106 listed in list.dnswl.org]
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
Cc: openldap-***@openldap.org
X-BeenThere: openldap-***@openldap.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: OpenLDAP development discussion list <openldap-devel.openldap.org>
List-Unsubscribe: <http://www.openldap.org/lists/mm/options/openldap-devel>,
<mailto:openldap-devel-***@openldap.org?subject=unsubscribe>
List-Archive: <http://www.openldap.org/lists/openldap-devel/>
List-Post: <mailto:openldap-***@openldap.org>
List-Help: <mailto:openldap-devel-***@openldap.org?subject=help>
List-Subscribe: <http://www.openldap.org/lists/mm/listinfo/openldap-devel>,
<mailto:openldap-devel-***@openldap.org?subject=subscribe>
Errors-To: openldap-devel-***@openldap.org
Sender: "openldap-devel" <openldap-devel-***@openldap.org>
X-Spam-Score: -4.2 (----)
X-Spam-Report: Spam detection software, running on the system "gauss.openldap.net", has
identified this incoming email as possible spam. The original message
has been attached to this so you can view it (if it isn't spam) or label
similar future email. If you have any questions, see
the administrator of that system for details.

Content preview: Леонид Юрьев wrote: > Hm, but how open dbi which
some flags, ensure that are present? > > Same for main-dbi without change
stored flags? If you want to verify which flags are present, use mdb_dbi_flags()
to retrieve them after opening. [...]

Content analysis details: (-4.2 points, 5.0 required)

pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium
trust
[69.43.206.106 listed in list.dnswl.org]
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
Hm, but how open dbi which some flags, ensure that are present?
Same for main-dbi without change stored flags?
If you want to verify which flags are present, use mdb_dbi_flags() to
retrieve them after opening.

This is why most of your posts meet negative responses - you attempt to
make changes before understanding how the existing system works. That's
not a good or productive approach to software development.
Hi, Howard.
I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.
This flag is completely unnecessary. Opening an existing DBI with
flags=0 accomplishes that task already.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Леонид Юрьев
2015-04-30 16:55:13 UTC
Permalink
Ok, I will refine my changes.
Thanks.
Post by Howard Chu
Hm, but how open dbi which some flags, ensure that are present?
Same for main-dbi without change stored flags?
If you want to verify which flags are present, use mdb_dbi_flags() to
retrieve them after opening.
This is why most of your posts meet negative responses - you attempt to
make changes before understanding how the existing system works. That's not
a good or productive approach to software development.
Hi, Howard.
I would like to introduce the MDB_PICKUP flag for mdb_dpi_open().
Please see
https://github.com/ReOpen/ReOpenLDAP/commit/04f92c952e42ff4c843135c42fdb9aa4b70a34fe
At least, this is required for mdb_chk tool, when a DBI should be opened
with flags that stored inside LMDB, which while a DBI was created. It is
particularly important for DBI_MAIN.
This flag is completely unnecessary. Opening an existing DBI with
flags=0 accomplishes that task already.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Loading...